Skip to content

[Implement] Buffer.compare #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jtenner wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Implement] Buffer.compare #7

jtenner wants to merge 2 commits into from

Conversation

@jtenner
Copy link
Contributor

@jtenner jtenner commented Jul 19, 2019 •
edited
Loading

Notes:

  • this function works really nicely with memory.compare()
  • Currently, the compiler doesn't like using static functions as function parameters (Will open an issue in the AssemblyScript repo)
ERROR AS218: Cannot access method 'compare' without calling it as it requires 'this' to be set.

     actual.sort(Buffer.compare);
                 ~~~~~~~~~~~~~~
 in tests/buffer.spec.ts(60,16)

Edit:

  • Switching to static readonly function expression causes this to compile

@jtenner jtenner requested a review from dcodeIO July 19, 2019 19:53
@jtenner jtenner self-assigned this Jul 19, 2019
@jtenner jtenner added the enhancement New feature or request label Jul 19, 2019
@jtenner jtenner mentioned this pull request Jul 19, 2019
Closed
@jtenner
Copy link
Contributor Author

jtenner commented Jul 23, 2019

With the static function fix, everything seems to look nice. Thoughts? @dcodeIO

@jtenner
Copy link
Contributor Author

jtenner commented Aug 1, 2019

TODO: Implement Buffer#compare.
TODO: Return 1, 0, or -1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcodeIO dcodeIO Awaiting requested review from dcodeIO

Assignees

@jtenner jtenner

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jtenner