Skip to content

feat: Add trueish conversion for v128 types #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MaxGraey merged 1 commit into from
Nov 11, 2021
Merged

feat: Add trueish conversion for v128 types #2135

MaxGraey merged 1 commit into from
Nov 11, 2021

Conversation

@MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Nov 11, 2021

It allow do this now:

export function foo(x: v128): i32 {
  if (x) { // internally uses v128.any_true(x)
     return -1;
  }
  return 0;
}
  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@MaxGraey MaxGraey requested a review from dcodeIO November 11, 2021 15:08
@MaxGraey MaxGraey merged commit 584bacf into AssemblyScript:main Nov 11, 2021
@MaxGraey MaxGraey deleted the v128-trueish branch November 11, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MaxGraey @dcodeIO