[DRAFT] Add support for using PageIndicatorView#675
Draft
Conversation
paolorotolo
requested changes
May 22, 2019
appintro-indicators/build.gradle
Outdated
| apply plugin: 'kotlin-android' | ||
| apply plugin: 'maven' | ||
| apply plugin: 'signing' | ||
| apply from: 'maven-push.gradle' |
Member
There was a problem hiding this comment.
You can probably drop this as well as the gradle script. Sonatype was used in the early versions of the library.
Member
Author
|
Yeah that makes sense,
I'm going to push a new PR that will cleanup the old publishing setup so we
have only JitPack so far.
…On Wed, May 22, 2019 at 5:16 PM Paolo Rotolo ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In appintro-indicators/build.gradle
<#675 (comment)>:
> @@ -0,0 +1,30 @@
+apply plugin: 'com.android.library'
+apply plugin: 'kotlin-android'
+apply plugin: 'maven'
+apply plugin: 'signing'
+apply from: 'maven-push.gradle'
You can probably drop this as well as the gradle script. Sonatype was used
in the early versions of the library.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#675?email_source=notifications&email_token=AAW44ZP4I3HPMB3QIXIJFMTPWVPUTA5CNFSM4HMZEPCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZMM3BY#pullrequestreview-240700807>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAW44ZIDGLCQX2OKLN2FVSDPWVPUTANCNFSM4HMZEPCA>
.
--
Nicola Corti - Android @ Yelp
corti.nico@gmail.com
http://ncorti.com
"Look wide, and even when you think you are looking wide – look wider
still!"
|
Member
Author
|
Here you go @paolorotolo #680 |
cortinico
force-pushed
the
custom-indicator
branch
from
fb791ab to
9b7c9ee
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a Draft PR for #619. I've added a new module
appintro-indicatorsthat developers can use in order to use aPageIndicatorView(and it's animation) as indicator.Here a sample:
Please note that this is not production ready yet. We probably need to:
AnimationTypeenum inside the module (we don't want developers to manually depend on thepageindicatorview, the module should work out of the box).Looking for some early feedback :) @paolorotolo @AnuthaDev
Fixes #619 Fixes #522