Skip to content

Commit f861ee1

Browse files
committed
Fix timeout for webhook http request
1 parent c81ed85 commit f861ee1

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

api/pkg/services/webhook_service.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -196,9 +196,12 @@ func (service *WebhookService) sendNotification(ctx context.Context, event cloud
196196
ctx, span, ctxLogger := service.tracer.StartWithLogger(ctx, service.logger)
197197
defer span.End()
198198

199+
ctx, cancel := context.WithTimeout(ctx, 5*time.Second)
200+
defer cancel()
201+
199202
request, err := service.createRequest(ctx, event, webhook)
200203
if err != nil {
201-
msg := fmt.Sprintf("cannot send [%s] event to webhook [%s] for user [%s]", event.Type(), webhook.URL, webhook.UserID)
204+
msg := fmt.Sprintf("cannot create [%s] event to webhook [%s] for user [%s]", event.Type(), webhook.URL, webhook.UserID)
202205
ctxLogger.Error(service.tracer.WrapErrorSpan(span, stacktrace.Propagate(err, msg)))
203206
return
204207
}
@@ -230,9 +233,6 @@ func (service *WebhookService) createRequest(ctx context.Context, event cloudeve
230233
ctx, span, ctxLogger := service.tracer.StartWithLogger(ctx, service.logger)
231234
defer span.End()
232235

233-
ctx, cancel := context.WithTimeout(ctx, 5*time.Second)
234-
defer cancel()
235-
236236
payload, err := json.Marshal(service.getPayload(ctxLogger, event, webhook))
237237
if err != nil {
238238
msg := fmt.Sprintf("cannot marshal payload for user [%s] and webhook [%s] for event [%s]", webhook.UserID, webhook.ID, event.ID())

0 commit comments

Comments
 (0)