fix: feedback widget overlapping messages on mobile#877
Draft
RhysSullivan wants to merge 2 commits intomainfrom
Draft
fix: feedback widget overlapping messages on mobile#877RhysSullivan wants to merge 2 commits intomainfrom
RhysSullivan wants to merge 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #874
Problem
The 'was this page helpful?' feedback widget was merging/overlapping with messages on mobile when the viewport was tall but thin (like a phone). The text also moved weirdly during scroll.
Solution
Changed the sticky positioning from `[@media(min-height:800px)]:sticky` to `md:sticky`.
Previously, the widget became sticky when viewport height was ≥800px regardless of width, which caused overlap issues on narrow mobile screens with tall viewports.
Now the widget only becomes sticky on medium-width screens and up (≥768px), preventing the sticky behavior entirely on narrow mobile viewports where it was causing overlap issues.
Testing