Fix AttributeError in NBMasterBar.show() when self.out is not initialized#119
Open
yuranpereira wants to merge 1 commit intoAnswerDotAI:masterfrom
Open
Fix AttributeError in NBMasterBar.show() when self.out is not initialized#119yuranpereira wants to merge 1 commit intoAnswerDotAI:masterfrom
yuranpereira wants to merge 1 commit intoAnswerDotAI:masterfrom
Conversation
…ized Problem In certain Jupyter environments (like VS Code and some local JupyterLab setups), calling `learn.fine_tune()` in fastai crashes with: ``` AttributeError: 'NBMasterBar' object has no attribute 'out' ``` This occurs because `show()` is called during the `before_fit` event (via `write()`), which happens before `on_iter_begin()` initializes `self.out`. This patch adds `hasattr(self, 'out')` check before calling `self.out.update()` in the `show()` method which is consistent with how `on_iter_end()` and `on_interrupt()` already handle this attribute. Current workarounds Users currently work around this by: - Using `with learn.no_bar(): learn.fine_tune(1)` - Or by completely disabling progress callbacks This fix eliminates the need for these workarounds. I tested this locally in Jupyter environment with fastai/fastbook Chapter 1 where it previously crashed. After applying this fix, the progress bars display correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In certain Jupyter environments (like VS Code and some local JupyterLab setups), calling
learn.fine_tune()in fastai crashes with:This occurs because
show()is called during thebefore_fitevent (viawrite()), which happens beforeon_iter_begin()initializesself.out.This patch adds
hasattr(self, 'out')check before callingself.out.update()in theshow()method which is consistent with howon_iter_end()andon_interrupt()already handle this attribute.Current workarounds
Users currently work around this by:
with learn.no_bar(): learn.fine_tune(1)This fix eliminates the need for these workarounds.
I tested this locally in Jupyter environment with fastai/fastbook Chapter 1 where it previously crashed. After applying this fix, the progress bars display correctly.