Skip to content

Changed logistic model code to match description#50

Open
EricRobertCampbell wants to merge 1 commit into
AllenDowney:masterfrom
EricRobertCampbell:chapter-10-typo
Open

Changed logistic model code to match description#50
EricRobertCampbell wants to merge 1 commit into
AllenDowney:masterfrom
EricRobertCampbell:chapter-10-typo

Conversation

@EricRobertCampbell
Copy link
Copy Markdown

@EricRobertCampbell EricRobertCampbell commented Oct 6, 2021

  • In the final exercise, in the exponent of the exponential, the
    parameter a is multiplying the other term
  • However, in the accompanying code, the parameter a is dividing it
  • The accompanying Wikipedia link about Item Response Theory also uses
    the convention of multiplying in the factor a
  • Easy fix: in the code switch a from a = 100 to a = 1 / 100, and
    switch it to multiplication in the assignment to x
  • Code change:
    new_code
  • Closes Chapter 10 Solutions - Definition / Implementation mismatch for the logistic #49

- In the final exercise, in the exponent of the exponential, the
  parameter `a` is multiplying the other term
- However, in the accompanying code, the parameter `a` is dividing it
- The accompanying Wikipedia link about Item Response Theory also uses
  the convention of multiplying in the factor `a`
- Easy fix: in the code switch `a` from `a = 100` to `a = 1 / 100`, and
  switch it it multiplication in the assignment to `x`
- Closes AllenDowney#49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chapter 10 Solutions - Definition / Implementation mismatch for the logistic

1 participant