Repository navigation
Prefer DB_PATH for phpMyAdmin SQLite connections - #2
Merged
Merged
Conversation
Use the path resolved by WordPress before the legacy FQDB constant, preserving the empty-path fallback when neither is defined. Ports WordPress/openstation#963. WordPress/sqlite-database-integration#512
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports WordPress/openstation#963 to this extension.
SQLite Database Integration now uses
DB_PATHas the primary database path setting. Legacy constants remain supported, butDB_PATHtakes precedence when both are defined.This makes phpMyAdmin follow the same precedence as the integration's own drop-in (
DB_PATH, thenFQDB), so it opens the active WordPress database when the two constants disagree.FQDBremains the fallback for older integration versions, and the existing behavior when neither constant is defined is preserved.Randomized storage works through the path constants the drop-in resolves, so no directory scanning or separate storage initialization is needed.
The
connect()change is identical to the one merged in OpenStation; only the surrounding comments are touched otherwise. Thewp-desktop-modemarker thatwindow.phpuses to restore the stock driver is unchanged.Related: Randomized SQLite storage (#502) and
DB_PATHsupport (#512).Testing
DB_PATHthat differs fromFQDBinwp-config.phpand confirm phpMyAdmin shows the same data as WordPress (edit a row in one, see it in the other).