fix: resolve webdav decode issue (#9268)

okatu-loli · alist666 · web-flow · commit 97d4f79b9633 · 2025-08-16T20:55:17.000+08:00
* fix: resolve webdav handshake error in permission checks - Updated role permission logic to handle bidirectional subpaths, fixing handshake termination by remote host due to path mismatch. - Refactored function naming for consistency and clarity. - Enhanced filtering of objects based on user permissions. - Modified `makePropstatResponse` to preserve encoded href paths. - Added test for `makePropstatResponse` to ensure href encoding. * Delete server/webdav/makepropstatresponse_test.go * ci(workflow): set GOPROXY for Go builds on GitHub Actions - Use `GOPROXY=https://proxy.golang.org,direct` to speed up module downloads - Mitigates network flakiness (e.g., checksum DB timeouts/rate limits) - `,direct` provides fallback for private/unproxyable modules - No build logic changes; only affects dependency resolution across all matrix targets --------- Co-authored-by: AlistGo <opsgit88@gmail.com>
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -25,6 +25,8 @@ jobs:
           - android-arm64
     name: Build
     runs-on: ${{ matrix.platform }}
+    env:
+      GOPROXY: https://proxy.golang.org,direct
     steps:
 
       - name: Checkout
diff --git a/server/webdav/webdav.go b/server/webdav/webdav.go
@@ -833,7 +833,7 @@ func (h *Handler) handleProppatch(w http.ResponseWriter, r *http.Request) (statu
 
 func makePropstatResponse(href string, pstats []Propstat) *response {
 	resp := response{
-		Href:     []string{(&url.URL{Path: href}).EscapedPath()},
+		Href:     []string{href},
 		Propstat: make([]propstat, 0, len(pstats)),
 	}
 	for _, p := range pstats {

Original file line number	Diff line number	Diff line change
`@@ -833,7 +833,7 @@ func (h Handler) handleProppatch(w http.ResponseWriter, r http.Request) (statu`
`833`	`833`
`834`	`834`	`func makePropstatResponse(href string, pstats []Propstat) *response {`
`835`	`835`	`resp := response{`
`836`		`- Href: []string{(&url.URL{Path: href}).EscapedPath()},`
	`836`	`+ Href: []string{href},`
`837`	`837`	`Propstat: make([]propstat, 0, len(pstats)),`
`838`	`838`	`}`
`839`	`839`	`for _, p := range pstats {`