Properly handle object lifetime - #2690
Merged
Merged
Conversation
Taking ownership of DPL provided objects is wrong.
ktf
requested review from
Barthelemy,
justonedev1 and
knopers8
as code owners
September 15, 2026 02:29
Open
Collaborator
|
I'll let @knopers8 review it |
knopers8
approved these changes
Sep 15, 2026
knopers8
left a comment
knopers8
left a comment
Collaborator
There was a problem hiding this comment.
Out of curiosity, did it cause trouble or are you just fixing a warning? It looks like the pointer is never accessed outside of this scope.
And speaking of stealing the framework's belongings, we also do this ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking ownership of DPL provided objects is wrong.