Change --require-tpc-lumi option to --lumi-type <type>#1325
Merged
chiarazampolli merged 1 commit intoAliceO2Group:masterfrom Nov 14, 2023
Merged
Change --require-tpc-lumi option to --lumi-type <type>#1325chiarazampolli merged 1 commit intoAliceO2Group:masterfrom
chiarazampolli merged 1 commit intoAliceO2Group:masterfrom
Conversation
Following PR#12205 and PR#12237 instead of boolean switch --require-tpc-lumi one should use --lumi-type <int_type> option with the meaning: 0 : no dynamic scaling 1 : require CTP lumi for TPC correction scaling 2 : require TPC scalers from CCDB for TPC correction scaling --lumi-type 1 corresponds to previous ALIEN_JDL_INSTIRFORTPC=CTP --lumi-type 2 corresponds to previous ALIEN_JDL_INSTIRFORTPC=IDCCCDB
shahor02
requested review from
benedikt-voelkel,
chiarazampolli,
davidrohr,
martenole and
sawenzel
as code owners
Collaborator
Author
|
@chiarazampolli this requires both AliceO2Group/AliceO2#12205 and AliceO2Group/AliceO2#12237 merged |
shahor02
commented
Nov 13, 2023
| @@ -193,8 +193,9 @@ def parse_important_DPL_args(cmds, flat_config): | |||
| s2 = extract_args(tokens, '--corrmap-lumi-mean') | |||
Collaborator
Author
There was a problem hiding this comment.
@sawenzel note that the option
O2DPG/UTILS/parse-async-WorkflowConfig.py
Lines 188 to 200 in a3194cd
o2-secondary-vertexing-workflow, o2-tof-matcher-workflow, o2-trd-global-tracking and o2-tpc-reco-workflow (and o2-gpu-reco-workflow). If one gets this option then all get it. Perhaps one can write a function to avoid copy-pasting the same line which are prone to change?
Collaborator
Collaborator
Author
There was a problem hiding this comment.
Since we don't currently use distortions in the MC, I am not sure what was the point of copying these options from the ITS-TPC matching.
For me it is fine to merge this, but then, it obviously cannot be used on the async-stable w/o porting PR#12205 and PR#12237.
Collaborator
Collaborator
|
Merging, if a better layout with a function can be done, it can be taken later. |
benedikt-voelkel
added
2022pp_apass4
async-2023-pbpb-apass4
benedikt-voelkel
added
async-2023-pbpb-apass3-accepted
and removed
async-2023-pbpb-apass4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following PR#12205 and PR#12237 instead of boolean switch --require-tpc-lumi one should use --lumi-type <int_type> option with the meaning:
0 : no dynamic scaling
1 : require CTP lumi for TPC correction scaling
2 : require TPC scalers from CCDB for TPC correction scaling
--lumi-type 1 corresponds to previous ALIEN_JDL_INSTIRFORTPC=CTP --lumi-type 2 corresponds to previous ALIEN_JDL_INSTIRFORTPC=IDCCCDB