Merged
Conversation
Instead of warnings and boolean return values use exception in case of out of range errors. Two types of exceptions are implemented: - InvalidPixelException dealing with pixels out of range - OutOfActiveAreaException dealing with local (chip) coordinates exceeding the active area of the chip Functions to which these cases might apply are updaged in the way that they throw exceptions in case of errors and do not return any value.
- handling of addresses for connecting sockets in DDS mode - printout of some additional information - moved user init to new InitTask function - removed Shutdown function which becomes non-virtual soon
- FLP and EPN tasks defined in collections and multiplied by groups - small setup of 2 FLP and 4 EPN nodes on HLT dev cluster - replacing the FileWriter by a BlockFilter to simply collect the processing brahces
- adding task and collection index in the device id - using collection index to determine the configuration file of the ClusterPublisher
Otherwise this causes an error when compiling on Mac with the latest xcode.
- Return 0 to avoid random result. - Assert in case code cannot / should not be reached.
ZMQ headers referred, but ZMQ not added to include path.
std:: is not really defined yet, so clang on mac actually complains about an implicitly defined namespace in the using statement.
Since 82XX there is only Pythia::init(). This mimicks the old, multi-argument Pythia::init(..).
Geant3 is not reqiured anymore if the Pythia 6 & 8 not found we do not build the Generators if AliRoot is not found we do not build the HLT-Wrappers
Copy ROOTMacros.cmake from FairRoot to cmake/modules. Do some small change in the cmake script which is needed to find all include directories. Change the directory order of the CMAKE_MODULE_PATH such that cmake/modules has highest priority. Search for package IWYU and create build target to use it.
Use the tool include-what-you-use to clean the include files
Remove MAC only includes
- Rename channels for FLP2EPN-distributed devices according to their roles. Separate channel per role - data-in, hb-in (heartbeat), data-out, hb-out. - Provide default values for various program options for FLP2EPN-distributed. The default values correspond to the normal run mode (full chain scenario). - Use ExpectsAnotherPart() for checking for multi-part messages. - Use CheckCurrentState() for state checks (thread-safe). - Remove signal handler functions from separate devices. Signal handler now resides in the base FairMQDevice class. To use it, device must call CatchSignals() method in the main. Alternatively, define your own signal handler for custom cleanup. - Use InteractiveStateLoop() helper method for manualy controlling devices from the console and test the state transitions. This is only usefull for manual run. When running with DDS this method will exit immediately because no console input is possible.
…e top level README.md file Remove unused AliceO2Doxygen.conf configuration file Remove trailing whitespaces from the Doxygen configuration file Rewording of the README.md files
EmilGorm
pushed a commit
to EmilGorm/AliceO2
that referenced
this pull request
Nov 22, 2021
* PWGHF: Add new Xicc cut variables * Fixing clang-format in HFSelectorCuts * Fixing decayLengthXY usage and comment alignment * Replace TMath::Abs with std::abs * Add selection on mass window for Xicc candidates * Fix in clang format * Fix comment alignment
alibuild
added a commit
to alibuild/AliceO2
that referenced
this pull request
Nov 30, 2023
shahor02
pushed a commit
that referenced
this pull request
Dec 4, 2023
* Update reconstruction objects (#83) * Update reconstruction objects * Update ZDCTowerParam.cxx * Tune intercalib (#84) * Small update to intercalibration * Small update to intercalibration * Please consider the following formatting changes (#81) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com> * Tuning of intercalibration - WIP * - corrected centroid computation for ZP calorimeters - rms of ZP centroid - updates in Intercalibration - introduction of offsets for energy and amplitud calibration * Please consider the following formatting changes (#85) * Modify offset for channels that are directly calibrated * Fix bug * ADC and TDC offsets * Please consider the following formatting changes (#86) * Fixes * Amplitude cannot be calibrated in GeV. Use RecEventFlat to set unit of measurement * Fixes * Fixes * Fixes * Fixes * Please consider the following formatting changes (#87) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
andreasmolander
pushed a commit
to andreasmolander/AliceO2
that referenced
this pull request
Apr 12, 2024
* Update reconstruction objects (AliceO2Group#83) * Update reconstruction objects * Update ZDCTowerParam.cxx * Tune intercalib (AliceO2Group#84) * Small update to intercalibration * Small update to intercalibration * Please consider the following formatting changes (AliceO2Group#81) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com> * Tuning of intercalibration - WIP * - corrected centroid computation for ZP calorimeters - rms of ZP centroid - updates in Intercalibration - introduction of offsets for energy and amplitud calibration * Please consider the following formatting changes (AliceO2Group#85) * Modify offset for channels that are directly calibrated * Fix bug * ADC and TDC offsets * Please consider the following formatting changes (AliceO2Group#86) * Fixes * Amplitude cannot be calibrated in GeV. Use RecEventFlat to set unit of measurement * Fixes * Fixes * Fixes * Fixes * Please consider the following formatting changes (AliceO2Group#87) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
mwinn2
pushed a commit
to mwinn2/AliceO2
that referenced
this pull request
Apr 25, 2024
* Update reconstruction objects (AliceO2Group#83) * Update reconstruction objects * Update ZDCTowerParam.cxx * Tune intercalib (AliceO2Group#84) * Small update to intercalibration * Small update to intercalibration * Please consider the following formatting changes (AliceO2Group#81) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com> * Tuning of intercalibration - WIP * - corrected centroid computation for ZP calorimeters - rms of ZP centroid - updates in Intercalibration - introduction of offsets for energy and amplitud calibration * Please consider the following formatting changes (AliceO2Group#85) * Modify offset for channels that are directly calibrated * Fix bug * ADC and TDC offsets * Please consider the following formatting changes (AliceO2Group#86) * Fixes * Amplitude cannot be calibrated in GeV. Use RecEventFlat to set unit of measurement * Fixes * Fixes * Fixes * Fixes * Please consider the following formatting changes (AliceO2Group#87) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are to reflect the similarities between the ITS and the (future) MFT code. They affect the directory structure only: the its/ has now been moved to the newly created itsmft/ (to the same level as the currently empty common/ and mft/ directories).