Skip to content

FIT: fix undefined behaviour in LookUpTable#8415

Merged
ktf merged 1 commit intodevfrom
ktf-patch-6
Mar 22, 2022
Merged

FIT: fix undefined behaviour in LookUpTable#8415
ktf merged 1 commit intodevfrom
ktf-patch-6

Conversation

@ktf
Copy link
Copy Markdown
Member

@ktf ktf commented Mar 22, 2022

No description provided.

@ktf
Copy link
Copy Markdown
Member Author

ktf commented Mar 22, 2022

Relying on the fact that equality will not be called in the case of a perfect hash is undefined behaviour. E.g. hashes can be bucketed and a linked list can be kept for a given bucket. This in particular breaks clang on macOS. Having the proper equality operators fixes the issue.

@mslupeck
Copy link
Copy Markdown
Collaborator

@afurs - I think this is your area

@afurs
Copy link
Copy Markdown
Collaborator

afurs commented Mar 22, 2022

@mslupeck it is OK. There was an issue after MacOS compiler update(stdlib)

@ktf ktf merged commit 8ca3f76 into dev Mar 22, 2022
@ktf ktf deleted the ktf-patch-6 branch March 22, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants