Skip to content

Fix protection against concurrent lock directory creation #8414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahor02 merged 1 commit into from
Mar 22, 2022
Merged

Fix protection against concurrent lock directory creation #8414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Detectors/CTF/workflow/src/CTFWriterSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,8 @@ void CTFWriterSpec::init(InitContext& ic)
mChkSize = std::max(size_t(mMinSize * 1.1), mMaxSize);
if (!std::filesystem::exists(LOCKFileDir)) {
if (!std::filesystem::create_directories(LOCKFileDir)) {
usleep(10); // protection in case the directory was created by other process at the time of query
if (std::filesystem::exists(LOCKFileDir)) {
usleep(10); // protection in case the directory was being created by other process at the time of query
if (!std::filesystem::exists(LOCKFileDir)) {
throw std::runtime_error(fmt::format("Failed to create {} directory", LOCKFileDir));
}
}
Expand Down