TPC simulation: fix bug where not all hits are stored when a track crosses the centre of a sector#8412
Merged
sawenzel merged 1 commit intoAliceO2Group:devfrom Mar 22, 2022
Merged
Conversation
…osses the centre of a sector When the shifted sector (centre of the sector) or the track ID changes during storage of the hits in the simulation, the first hit of the new sector/particle were not stored. This led to lower cluster charge in the centre of a sector for tracks which crosses the centre of a sector.
matthias-kleiner
requested review from
davidrohr,
shahor02 and
wiechula
as code owners
wiechula
approved these changes
Mar 21, 2022
Collaborator
wiechula
left a comment
wiechula
left a comment
There was a problem hiding this comment.
Very nice! Thanks a lot for the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the shifted sector (centre of the sector) or the track ID changes during storage of the hits in the simulation, the first hit of the new sector/particle were not stored.
This led to lower cluster charge in the centre of a sector for tracks which crosses the centre of a sector.