Skip to content

Fix AO2Ds in case of negative first daughter #8391

Merged
sawenzel merged 1 commit intoAliceO2Group:devfrom
mpuccio:patch-4
Mar 22, 2022
Merged

Fix AO2Ds in case of negative first daughter #8391
sawenzel merged 1 commit intoAliceO2Group:devfrom
mpuccio:patch-4

Conversation

@mpuccio
Copy link
Copy Markdown
Contributor

@mpuccio mpuccio commented Mar 18, 2022

@mpuccio mpuccio requested a review from a team as a code owner March 18, 2022 10:00
jgrosseo
jgrosseo previously approved these changes Mar 18, 2022
@jgrosseo jgrosseo requested a review from sawenzel March 18, 2022 10:11
@jgrosseo
Copy link
Copy Markdown
Collaborator

@sawenzel This check will most likely break all ongoing productions (from @mpuccio investigation), it is still the right thing to do...

@chiarazampolli
Copy link
Copy Markdown
Collaborator

Hi @jgrosseo ,

Do you mean that from the moment when it is merged, all jobs will fail, not passing the test?
See also my comment in https://alice.its.cern.ch/jira/browse/O2-2820

Chiara

@jgrosseo
Copy link
Copy Markdown
Collaborator

This concerns only MC. Probably not all but quite some will fail. At least Max found this in a number of AODs. I do not have answers to your other questions in the ticket...

@sawenzel sawenzel closed this Mar 18, 2022
@sawenzel sawenzel reopened this Mar 18, 2022
@mpuccio
Copy link
Copy Markdown
Contributor Author

mpuccio commented Mar 21, 2022

Hello everyone, after discussing with @sawenzel we came to the conclusion that these cases might be due to pruned particles in the kinematics. We will have a look in details to check that this is the case and that no physics is harmed (there is already quite some certainty about this, as the keepPhysics function in Stack keeps primaries and their offsprings).
The current solution will make the AO2D conforming to the data model and will not disrupt current productions.

@mpuccio mpuccio changed the title Break before producing faulty AO2Ds Fix AO2Ds in case of negative first daughter Mar 21, 2022
@sawenzel sawenzel merged commit e3dfff4 into AliceO2Group:dev Mar 22, 2022
@mpuccio mpuccio deleted the patch-4 branch March 22, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants