Skip to content

DPL: expire Optional inputs only when a given message is provided#8384

Merged
davidrohr merged 1 commit intoAliceO2Group:devfrom
ktf:expire-optional-diststf
Mar 17, 2022
Merged

DPL: expire Optional inputs only when a given message is provided#8384
davidrohr merged 1 commit intoAliceO2Group:devfrom
ktf:expire-optional-diststf

Conversation

@ktf
Copy link
Copy Markdown
Member

@ktf ktf commented Mar 17, 2022

No description provided.

@ktf ktf requested a review from a team as a code owner March 17, 2022 22:29
@ktf
Copy link
Copy Markdown
Member Author

ktf commented Mar 17, 2022

@davidrohr @shahor02 not tested yet, but at least compiles. Notice that for this to work the optional input must come after the DISTSTF one.

@davidrohr
Copy link
Copy Markdown
Collaborator

seems to work, merging to have it in tomorrow's build

@davidrohr davidrohr merged commit bceebd0 into AliceO2Group:dev Mar 17, 2022
@shahor02
Copy link
Copy Markdown
Collaborator

Notice that for this to work the optional input must come after the DISTSTF one.

Could you clarify this point? If you mean the ordering in the specs definition, in many devices this is not the case

@davidrohr
Copy link
Copy Markdown
Collaborator

I just tried it in the FST and seemed to be OK. I thought it referred to arrival time, and the optional inputs are the raw data so they should arrive together with the DISTSTF. But @ktf should clarify what exactly he means.

@ktf
Copy link
Copy Markdown
Member Author

ktf commented Mar 18, 2022

i actually meant what ruben meant . will check in a bit the actual details. if that's not the case the "dead beef" will simply not trigger.

@davidrohr
Copy link
Copy Markdown
Collaborator

i actually meant what ruben meant . will check in a bit the actual details. if that's not the case the "dead beef" will simply not trigger.

ok, but that is actually a bit error-prone. Can't this be changed? :)

@shahor02
Copy link
Copy Markdown
Collaborator

@ktf cannot you sort the inputs internally? If this is problematic, I can fix in a couple of hours the specs, putting the diststf to the head of the input.

@davidrohr
Copy link
Copy Markdown
Collaborator

I can fix in a couple of hours the specs, putting the diststf to the head of the input.

I am doing this right now to test it.
There is anyway a problem with the new O2, so we anyway need a new build.
Would still be good to check internally first if the distsubtimeframe is there.

@davidrohr
Copy link
Copy Markdown
Collaborator

#8387 should do it

@ktf
Copy link
Copy Markdown
Member Author

ktf commented Mar 18, 2022

i actually meant what ruben meant . will check in a bit the actual details. if that's not the case the "dead beef" will simply not trigger.

ok, but that is actually a bit error-prone. Can't this be changed? :)

Yes, I will change it now. It's just that currently the expiration mechanism is configured as I add the routes to the device. I will do it in a separate step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants