TPC dEdx: automatically loading calib objects from CCDB#8379
Merged
davidrohr merged 1 commit intoAliceO2Group:devfrom Mar 17, 2022
Merged
TPC dEdx: automatically loading calib objects from CCDB#8379davidrohr merged 1 commit intoAliceO2Group:devfrom
davidrohr merged 1 commit intoAliceO2Group:devfrom
Conversation
matthias-kleiner
requested review from
davidrohr,
sgorbuno,
shahor02 and
wiechula
as code owners
- adding options for disabling loading calibrations from CCDB - using the gain map to get the original charge which was used during the zero supresison - apply residual gain map on cluster charge - smooth zero supression threshold map - disable loading of CCDB objects, when calibs are set from file - TPC clusterer: automatically loading the gain map from the CCDB
matthias-kleiner
force-pushed
the
dedxdev
branch
from
50fc214 to
de71657
Compare
Contributor
Author
|
Hi @davidrohr , can you test if this PR is working now for you? @wiechula has uploaded all the calibrations to the official CCDB |
Collaborator
|
Yes, sure. This is for the PR I had to revert since it broke the TPC reco workflow? |
Contributor
Author
Yes, that was the reverted PR that broke the reco workflow |
wiechula
approved these changes
Mar 17, 2022
davidrohr
approved these changes
Mar 17, 2022
Collaborator
davidrohr
left a comment
davidrohr
left a comment
There was a problem hiding this comment.
tested and tpc tracking works correctly, can be merged when the CI is passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding options for disabling loading calibrations from CCDB
disable loading of CCDB objects, when calib ist set from file
using the gain map to get the original charge which was used during the zero supression
possibillity to apply gain map during the reconstruction of the dE/dx
'smooth' zero supression threshold map
apply residual gain map on cluster charge
TPC clusterer: automatically loading the gain map from the CCDB