Mch dcs fix start validity time#8368
Conversation
also make the DCSDPconfig valid up to infinity (instead of the default 1 day)
| << CcdbDpConfName() << "\n"; | ||
|
|
||
| api.storeAsTFileAny(&dpid2DataDesc, CcdbDpConfName(), md, timestamp); | ||
| uint64_t endOfValidity = 99999999999999; |
There was a problem hiding this comment.
Looks like my yesterday comment was lost by the github...
Why do you need infinite end validity? This will make every new object to overlap with all previous, which, afaik, leads to overhead. Is not it enough to add e.g. 1-2 days margin to start-time?
There was a problem hiding this comment.
Hi @shahor02 ,
I allow myself to jump in :-) I also think I replied to you this morning... Weird.
Anyway, this is the configuration entry, where they define which DPs to process, it is not expected to change often (if ever).
There was a problem hiding this comment.
Ah, ok, thanks for pointing this out.
shahor02
left a comment
There was a problem hiding this comment.
@chiarazampolli do you have comments on this, shall I merge it?
This is what we tested yesterday, fine with me to merge. Thanks! |
No description provided.