Skip to content

Mch dcs fix start validity time#8368

Merged
shahor02 merged 2 commits intoAliceO2Group:devfrom
aphecetche:mch-dcs-fix-start-validity-time
Mar 18, 2022
Merged

Mch dcs fix start validity time#8368
shahor02 merged 2 commits intoAliceO2Group:devfrom
aphecetche:mch-dcs-fix-start-validity-time

Conversation

@aphecetche
Copy link
Copy Markdown
Collaborator

No description provided.

also make the DCSDPconfig valid up to infinity (instead of the
default 1 day)
<< CcdbDpConfName() << "\n";

api.storeAsTFileAny(&dpid2DataDesc, CcdbDpConfName(), md, timestamp);
uint64_t endOfValidity = 99999999999999;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like my yesterday comment was lost by the github...
Why do you need infinite end validity? This will make every new object to overlap with all previous, which, afaik, leads to overhead. Is not it enough to add e.g. 1-2 days margin to start-time?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shahor02 ,
I allow myself to jump in :-) I also think I replied to you this morning... Weird.
Anyway, this is the configuration entry, where they define which DPs to process, it is not expected to change often (if ever).

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok, thanks for pointing this out.

Copy link
Copy Markdown
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chiarazampolli do you have comments on this, shall I merge it?

@chiarazampolli
Copy link
Copy Markdown
Collaborator

@chiarazampolli do you have comments on this, shall I merge it?

This is what we tested yesterday, fine with me to merge.

Thanks!

@shahor02 shahor02 merged commit 0d081fc into AliceO2Group:dev Mar 18, 2022
@aphecetche aphecetche deleted the mch-dcs-fix-start-validity-time branch March 23, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants