TrackletTransformer uses DPL CCDB mechanism#8363
Conversation
There was a problem hiding this comment.
We will need some other calibrations in this class as well, mainly for PID: the krypton gain tables and the chamber gain.
I would suggest to rename this member variable in preparation for that.
| const CalVdriftExB* mCalibration{nullptr}; | |
| const CalVdriftExB* mCalVdriftExB{nullptr}; |
There was a problem hiding this comment.
Why would we actually need those PID calibrations in this class? The CalibratedTracklet only stores position information and one direction. I thought this would be covered by vDrift and ExB? But T0 might come at some point, so I will do the naming change nevertheless
There was a problem hiding this comment.
Also here, we should prepare the inclusion of Kr and gain calibrations.
There was a problem hiding this comment.
I guess this no longer needs to be a member variable.
| mPadPlane = mGeo->getPadPlane(detector); | |
| auto padPlane = mGeo->getPadPlane(detector); |
There was a problem hiding this comment.
Well it is used in three other functions which are called from there, so one would need to pass it along every time. I would leave it as it is for now.
|
Hi @TimoWilken would it be possible for you to restart the fullCI test for this PR please? And could I get another approval from @bazinski perhaps? The only thing I changed wrt to previous version of this PR was the naming as suggested by Tom |
|
@martenole just out curiosity, and this is not a request to change, but why not std::shared_ptr ? |
|
The calibration objects which are obtained from the CCDB (e.g. |
|
Hi @martenole, the fullCI reran automatically, everything is green now. |
|
Hi @TimoWilken thanks a lot and sorry for the noise. I was not sure if it would be starting again automatically, since it already ran several times. |
5 participants
Hi @shahor02
with this patch the tracklet transformer uses the DPL CCDB fetching mechanism. The time stamp option has been removed.
Cheers,
Ole