Restructure init of sim magnetic field#8361
Merged
sawenzel merged 1 commit intoAliceO2Group:devfrom Mar 16, 2022
Merged
Conversation
Collaborator
Author
|
@chiarazampolli @shahor02 : After this, we can fetch the field from CCDB in anchored-sim. |
shahor02
previously approved these changes
Mar 15, 2022
Collaborator
shahor02
left a comment
shahor02
left a comment
There was a problem hiding this comment.
Looks fine. I guess later the same SimFieldUtils can be used to generate a local clone of the GRPMagField, to which ccdb queries should be remapped.
* move init code to common function and use multiple times * allow field init from CCDB (with --field ccdb)
sawenzel
force-pushed
the
swenzel/o2sim-field-ccdb
branch
from
be88b66 to
1afe0d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multiple times