Skip to content

TPC interpolation use correct global track index#8360

Merged
shahor02 merged 1 commit intoAliceO2Group:devfrom
martenole:tracklettransformer
Mar 16, 2022
Merged

TPC interpolation use correct global track index#8360
shahor02 merged 1 commit intoAliceO2Group:devfrom
martenole:tracklettransformer

Conversation

@martenole
Copy link
Copy Markdown
Contributor

@davidrohr this fixes the crash of the track interpolation. For ITS-TPC-TRD-TOF tracks the index in the GlobalIDSet which is filled by the RecoContainer::getSingleDetectorRefs() method puts the GID of the global track into the TRD slot, since no standalone TRD track exists. With that index one cannot request the TRD track. One has to use the reference for the ITS-TPC-TRD track instead.
I think at that time of the development there was an issue with the TOF matching which lead to the fact that there were no ITS-TPC-TRD-TOF tracks existing and that is why I did not see it.

@davidrohr
Copy link
Copy Markdown
Collaborator

thx, don't have time to double-check but fix seems trivial. Let's get this into tomorrow's build.

@martenole
Copy link
Copy Markdown
Contributor Author

thx, don't have time to double-check but fix seems trivial. Let's get this into tomorrow's build.

Fine with me. I have tried with your tmp-fst13 data set and with a small simulation I did myself

@martenole
Copy link
Copy Markdown
Contributor Author

Hi @davidrohr could you maybe merge this? At least the fullCI is green. And I see that other PRs are also failing because of the track interpolation: https://ali-ci.cern.ch/alice-build-logs/AliceO2Group/AliceO2/8362/f5e48d2b5a3f71475c00bf78308bf059ef328111/build_O2_fullCI/pretty.html
In general the CI seems to be very slow to me at the moment. E.g. #8170 is waiting for more than two days for the macOS build

Copy link
Copy Markdown
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes are trivial, merging

@shahor02 shahor02 merged commit 7c3cfad into AliceO2Group:dev Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants