Fix IB and OB geometry to latest blueprints#8358
Merged
shahor02 merged 2 commits intoAliceO2Group:devfrom Mar 16, 2022
Merged
Conversation
mario6829
requested review from
bovulpes,
iouribelikov,
mconcas and
rpezzi
as code owners
Collaborator
|
@mario6829 Looks good ! Let me just finish my usual formal checks... |
Collaborator
|
will merge after CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes some small but important geometry mismatches with latest blueprints. The IB chip position was not centered wrt to the stave, and the FPC and glue volumes were smaller and centered; whereas now the chip volume is centered in the X coordinate while the FPC and glue have the correct transverse dimension and are properly aligned to one end of the stave. Lastly the radial position of the stave of all OB layers were reduced to the correct value.