SpaceCharge: adding functionality to set boundary potentials#8357
Merged
davidrohr merged 1 commit intoAliceO2Group:devfrom Mar 18, 2022
Merged
SpaceCharge: adding functionality to set boundary potentials#8357davidrohr merged 1 commit intoAliceO2Group:devfrom
davidrohr merged 1 commit intoAliceO2Group:devfrom
Conversation
Contributor
matthias-kleiner
commented
Mar 15, 2022
matthias-kleiner
commented
- Boundary potentials can be set for the GEM frame and for the inner/outer field cage separately: dummy potential
- Removing unused variable in function
-Boundary potentials can be set for the GEM frame and for the inner/outer field cage - Removing unused variable in function
matthias-kleiner
requested review from
davidrohr,
shahor02 and
wiechula
as code owners
wiechula
approved these changes
Mar 15, 2022
Collaborator
|
@shahor02 , @davidrohr , fullCI failure seems unrelated. Can this be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.