Fix O2-2843: handling empty rofs#8356
Merged
shahor02 merged 2 commits intoAliceO2Group:devfrom Mar 18, 2022
Merged
Conversation
mpuccio
requested review from
bovulpes,
iouribelikov,
mconcas and
rpezzi
as code owners
Contributor
Author
|
@shahor02 , I confirm that I obtain the exact same result on MC and that the processing of the cosmics data you gave me does not crash. Ready to be merged as soon as the CI is green. |
shahor02
previously approved these changes
Mar 15, 2022
Collaborator
shahor02
left a comment
shahor02
left a comment
There was a problem hiding this comment.
Thanks! Code looks fine, will merge after CI has passed.
Contributor
Author
|
@shahor02 I think the fullCI is failing for a unrelated issue |
Collaborator
|
The fullCI did not rerun yet after fixing the alien-token. Did you try the reconstruction locally? |
Contributor
Author
|
Yes, and I get the same results before and after (I used the simulations from alibi to check, thanks to Benedikt) |
shahor02
approved these changes
Mar 18, 2022
Collaborator
shahor02
left a comment
shahor02
left a comment
There was a problem hiding this comment.
fullCI failure is unrelated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.