Conversation
|
This is a draft code for PHOS in the AOD producer. I have tried adapting EventHandler code from EMCAL, but I'm not sure if it is a correct way to access information. @peressounko, could you please check the code and see if it is ok for you? Also, I have a problem with accessing PHOS cells via RecoContainer -- I will create a JIRA ticket for this |
|
Thank you @shahor02, I will try running with this fix too |
|
Hi @shahor02. I have tested this PR with your fix, and it seems it works fine now. Thank you! @peressounko: I have updated the code to also add trigger information |
| template <class CellInputType> | ||
| bool EventHandler<CellInputType>::compareInteractionRecords(const InteractionRecord& lhs, const InteractionRecord& rhs) const | ||
| { | ||
| return lhs.bc == rhs.bc && lhs.orbit == rhs.orbit; | ||
| } |
There was a problem hiding this comment.
just for the record: InteractionRecord has operator==, so one can do directly lhs==rhs
| auto* caloEventHandler = new o2::emcal::EventHandler<o2::emcal::Cell>(); | ||
| fillCaloTable(caloEventHandler, caloEMCCells, caloEMCCellsTRGR, caloCellsCursor, caloCellsTRGTableCursor, bcsMap, 1); | ||
| delete caloEventHandler; |
There was a problem hiding this comment.
can you avoid new/delete, using instead stack object, i.e.
o2::emcal::EventHandler<o2::emcal::Cell> caloEventHandler;
fillCaloTable(&caloEventHandler, caloEMCCells, caloEMCCellsTRGR, caloCellsCursor, caloCellsTRGTableCursor, bcsMap, 1);
same for the PHOS. Can be done in different PR, since this one already passed CIs
|
merging after resolving trivial conflict, all tests were passed. |
2 participants
No description provided.