Merged
Conversation
…ons"" This reverts commit ce9e904.
Member
|
Currently broken on some arch... |
Collaborator
Author
|
Actually, I don't see how it can be broken, the switch-to-gsl-4 PR was green when it was merged. |
Member
|
Not sure either. I suspect there might be some interference with system includes. |
Member
|
(or maybe simply people did not recompile enough...) |
Contributor
|
Thank you
…________________________________________
From: Giulio Eulisse ***@***.***
Sent: 14 March 2022 16:02
To: AliceO2Group/AliceO2
Cc: Subscribed
Subject: Re: [AliceO2Group/AliceO2] Restore ms_gsl < 4 support (PR #8343)
(or maybe simply people did not recompile enough...)
—
Reply to this email directly, view it on GitHub<#8343 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEY4YNAEJQTBI5ELFQCUUCLU75IIHANCNFSM5QVXEPIQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Collaborator
|
I can confirm that updating alidist (before this commit, of course) fixed the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert "Revert "Workaround: temporarily support multiple ms_gsl versi…
This reverts commit ce9e904.