Skip to content

switch the variable initialization order #8337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 2 commits into from
Mar 21, 2022
Merged

switch the variable initialization order #8337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2baa93
switch the variable initialization order
zhaomr13 Mar 13, 2022
c0ef665
use size_t instead of int
zhaomr13 Mar 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Common/MathUtils/test/testUtils.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ BOOST_AUTO_TEST_CASE(Utils_test)
// dry run
sum = 0;
auto begin = std::chrono::high_resolution_clock::now();
for (int i = 0; i < iterations; ++i) {
for (size_t i = 0; i < iterations; ++i) {
for (int j = 0; j < M; ++j) {
sum += vx[j] + vy[j];
}
Expand All @@ -83,7 +83,7 @@ BOOST_AUTO_TEST_CASE(Utils_test)
// double precision
double dsum = 0;
begin = std::chrono::high_resolution_clock::now();
for (int i = 0; i < iterations; ++i) {
for (size_t i = 0; i < iterations; ++i) {
for (int j = 0; j < M; ++j) {
dsum += std::atan2(vyd[j], vxd[j]);
}
Expand All @@ -95,7 +95,7 @@ BOOST_AUTO_TEST_CASE(Utils_test)
// single precision
sum = 0;
begin = std::chrono::high_resolution_clock::now();
for (int i = 0; i < iterations; ++i) {
for (size_t i = 0; i < iterations; ++i) {
for (int j = 0; j < M; ++j) {
sum += atan2f(vy[j], vx[j]);
}
Expand All @@ -107,7 +107,7 @@ BOOST_AUTO_TEST_CASE(Utils_test)
// fast method
sum = 0;
begin = std::chrono::high_resolution_clock::now();
for (int i = 0; i < iterations; ++i) {
for (size_t i = 0; i < iterations; ++i) {
for (int j = 0; j < M; ++j) {
sum += math_utils::fastATan2(vy[j], vx[j]);
}
Expand Down
2 changes: 1 addition & 1 deletion DataFormats/Headers/include/Headers/TimeStamp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ class TimeStamp
TimeStamp() = default;
TimeStamp(uint64_t ts) : mTimeStamp64(ts) {}
TimeStamp(const TimeUnitID& unit, uint32_t tick, uint16_t subtick = 0)
: mUnit(unit), mTicks(tick), mSubTicks(subtick) {}
: mUnit(unit), mSubTicks(subtick), mTicks(tick) {}
~TimeStamp() = default;

static TimeUnitID const sClockLHC;
Expand Down