Skip to content

switch the variable initialization order#8337

Merged
ktf merged 2 commits intoAliceO2Group:devfrom
zhaomr13:dev
Mar 21, 2022
Merged

switch the variable initialization order#8337
ktf merged 2 commits intoAliceO2Group:devfrom
zhaomr13:dev

Conversation

@zhaomr13
Copy link
Copy Markdown
Contributor

No description provided.

@zhaomr13 zhaomr13 requested a review from a team as a code owner March 13, 2022 16:00
ktf
ktf previously approved these changes Mar 17, 2022
@zhaomr13
Copy link
Copy Markdown
Contributor Author

@ktf @shahor02
Giulio asked me to fix the warnings in the codes.
In principle I should fix one file in one PR. However I didn't realized this PR have not been merged and I fixed warnings in another file. But since the changes in the two files are both minor, I think it should be safety and most easier to use this PR for these two files.
Is it ok for you?

@ktf
Copy link
Copy Markdown
Member

ktf commented Mar 19, 2022

Could you please rebase the PR on top of the current dev branch?

@zhaomr13
Copy link
Copy Markdown
Contributor Author

Could you please rebase the PR on top of the current dev branch?

Rebased

@ktf ktf self-requested a review March 20, 2022 18:09
@zhaomr13
Copy link
Copy Markdown
Contributor Author

It failed on build/O2/o2-cs8, should I do something?

@ktf ktf merged commit 7abfa02 into AliceO2Group:dev Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants