Skip to content

DPL: fix warnings in DataAllocator.h #8333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Mar 13, 2022
Merged

DPL: fix warnings in DataAllocator.h #8333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Framework/Core/include/Framework/DataAllocator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class RecordBatchWriter;

namespace o2::framework
{
class ServiceRegistry;
struct ServiceRegistry;

#define ERROR_STRING \
"data type T not supported by API, " \
Expand Down Expand Up @@ -136,7 +136,7 @@ class DataAllocator
FairMQMessagePtr headerMessage = headerMessageFromOutput(spec, channel, o2::header::gSerializationMethodROOT, 0);
return context.add<MessageContext::RootSerializedObject<T>>(std::move(headerMessage), channel, std::forward<Args>(args)...).get();
} else if constexpr (std::is_base_of_v<std::string, T>) {
std::string* s = new std::string(args...);
auto* s = new std::string(args...);
adopt(spec, s);
return *s;
} else if constexpr (std::is_base_of_v<struct TableBuilder, T>) {
Expand Down Expand Up @@ -421,7 +421,7 @@ class DataAllocator
};

template <typename ContainerT>
CacheId adoptContainer(const Output& spec, ContainerT& container, bool cache = false, o2::header::SerializationMethod method = header::gSerializationMethodNone)
CacheId adoptContainer(const Output& /*spec*/, ContainerT& /*container*/, bool /* cache = false */, o2::header::SerializationMethod /* method = header::gSerializationMethodNone*/)
{
static_assert(always_static_assert_v<ContainerT>, "Container cannot be moved. Please make sure it is backed by a FairMQMemoryResource");
return {0};
Expand Down