Skip to content

TPC: DCS processing#8331

Merged
davidrohr merged 4 commits intoAliceO2Group:devfrom
wiechula:dcs
Mar 17, 2022
Merged

TPC: DCS processing#8331
davidrohr merged 4 commits intoAliceO2Group:devfrom
wiechula:dcs

Conversation

@wiechula
Copy link
Copy Markdown
Collaborator

  • Add DCS processing for TPC
  • Some unrelated fixes

@chiarazampolli
Copy link
Copy Markdown
Collaborator

Hello @wiechula ,

Thanks! I have an immediate feedback: on Friday, we found out that DCS modified the data they send, they are not of type "RAW" (e.g. RAW_FLOAT) but DPVAL (e.g. DPVAL_FLOAT), maybe you did not noticed you were mentioned here:

#8317 (comment)

Could you update the PR?

Cheers,

Chiara

@chiarazampolli
Copy link
Copy Markdown
Collaborator

Another question: is DARMA a tool to export to file the DCS DPs? We have a pending issue related to how to retrofit CCDB entries in case something goes wrong with the processing, and additionally I wanted to implement a dumping to file of what is read from ADAPOS, is this doing either of the two?

@wiechula
Copy link
Copy Markdown
Collaborator Author

@chiarazampolli , thanks for pointing this out. Indeed, I missed this message. I updated the PR.

DARMA is a web interface to export DCS DPs. For testing my development I downloaded 3 days of all our data points we want to send to ccdb. The code I added can play back this text file. At the moment all data is sent in one TF. The functionality can be extended, of course. But with this it is possible to easily send DPs to ccdb of older data. Although it is some manual work ...

@wiechula
Copy link
Copy Markdown
Collaborator Author

@davidrohr , @shahor02 , do you know if there is a problem with the CI? o2 and macOS are expected since more then 12h now.

@shahor02
Copy link
Copy Markdown
Collaborator

I've already asked @TimoWilken to check o2 in other PR, I also think they are stuck.

@wiechula
Copy link
Copy Markdown
Collaborator Author

Thanks @shahor02 !

@wiechula
Copy link
Copy Markdown
Collaborator Author

@TimoWilken , @shahor02 , o2 and macOS still didn't report, unfortunately. Could someone please check?

* data exported from DARMA can be directly played back via DPL
  and allows running the standard detector DCS workflow
* improve debugging information in DataPointCompositeObject
* add new data formats for DCS values
* move previous DCS code to separate folder
* implement DCS value processing
@wiechula
Copy link
Copy Markdown
Collaborator Author

@davidrohr , @shahor02 , can this be merged? The error in fullCI seems unrelated.

@davidrohr davidrohr merged commit 7bdfeca into AliceO2Group:dev Mar 17, 2022
@wiechula wiechula deleted the dcs branch March 19, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants