Skip to content

MCH: DCS DP change from RAW to DPVAL #8327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahor02 merged 1 commit into from
Mar 19, 2022
Merged

MCH: DCS DP change from RAW to DPVAL #8327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Detectors/MUON/Common/src/dcs-ccdb.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ void makeCCDBEntryForDCS(const std::string ccdbUrl, uint64_t timestamp)
DPID dpidtmp;
for (const auto& a : aliases) {
auto legitName = o2::muon::replaceDotByUnderscore(a);
DPID::FILL(dpidtmp, legitName, o2::dcs::DeliveryType::RAW_DOUBLE);
DPID::FILL(dpidtmp, legitName, o2::dcs::DeliveryType::DPVAL_DOUBLE);
dpid2DataDesc[dpidtmp] = fmt::format("{}DATAPOINTS", o2::muon ::subsysname());
}

Expand All @@ -120,7 +120,10 @@ void makeCCDBEntryForDCS(const std::string ccdbUrl, uint64_t timestamp)
<< o2::muon::subsysname() << " data points to "
<< CcdbDpConfName() << "\n";

api.storeAsTFileAny(&dpid2DataDesc, CcdbDpConfName(), md, timestamp);
uint64_t endOfValidity = 99999999999999;
Copy link
Copy Markdown
Collaborator

@shahor02 shahor02 Mar 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aphecetche why do you need infinite validity? In this way every next object will overlap will all previous, afaik, this will create overheads. Isn't e.g. 1-2 days validity enough?

Copy link
Copy Markdown
Collaborator

@chiarazampolli chiarazampolli Mar 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shahor02 .
This is the configuration object, determining which DPs to process.
Chiara


api.storeAsTFileAny(&dpid2DataDesc, CcdbDpConfName(), md, timestamp,
endOfValidity);
}

bool match(const std::vector<std::string>& queries, const char* pattern)
Expand Down