MCH: DCS DP change from RAW to DPVAL#8327
Merged
shahor02 merged 1 commit intoAliceO2Group:devfrom Mar 19, 2022
Merged
Conversation
also make the DCSDPconfig valid up to infinity (instead of the default 1 day)
Collaborator
|
Hi @aphecetche , Thanks! I must have overlooked this one, sorry. Yes, it is (hopefully) correct - we will know for sure only after testing, but GRP worked with this. Many thanks! Chiara |
shahor02
reviewed
Mar 17, 2022
| << CcdbDpConfName() << "\n"; | ||
|
|
||
| api.storeAsTFileAny(&dpid2DataDesc, CcdbDpConfName(), md, timestamp); | ||
| uint64_t endOfValidity = 99999999999999; |
Collaborator
There was a problem hiding this comment.
@aphecetche why do you need infinite validity? In this way every next object will overlap will all previous, afaik, this will create overheads. Isn't e.g. 1-2 days validity enough?
Collaborator
There was a problem hiding this comment.
Hi @shahor02 .
This is the configuration object, determining which DPs to process.
Chiara
shahor02
approved these changes
Mar 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also make the DCSDPconfig valid up to infinity (instead of the default 1 day)
@chiarazampolli I hope I interpreted correctly the change that was necessary.
Note that I've updated the MCH DP config in ccdb-test.cern.ch:8080 with this change
(if that works I'll do the same for MID during Monday's tests)