Skip to content

Adapt to type sent by DCS + macros to populate and read the GRP DCS config entry#8317

Merged
shahor02 merged 10 commits intoAliceO2Group:devfrom
chiarazampolli:GRPmacros
Mar 20, 2022
Merged

Adapt to type sent by DCS + macros to populate and read the GRP DCS config entry#8317
shahor02 merged 10 commits intoAliceO2Group:devfrom
chiarazampolli:GRPmacros

Conversation

@chiarazampolli
Copy link
Copy Markdown
Collaborator

@chiarazampolli chiarazampolli commented Mar 11, 2022

No description provided.

@chiarazampolli chiarazampolli requested a review from a team as a code owner March 11, 2022 11:25
@chiarazampolli chiarazampolli force-pushed the GRPmacros branch 3 times, most recently from 518974a to 0dfee37 Compare March 11, 2022 14:58
@chiarazampolli chiarazampolli changed the title macros to populate and read the GRP DCS config entry Adapt to type sent by DCS + macros to populate and read the GRP DCS config entry Mar 11, 2022
@chiarazampolli
Copy link
Copy Markdown
Collaborator Author

chiarazampolli commented Mar 11, 2022 •
edited
Loading

Hello @aphecetche , @wiechula , @mpoghos , @syano0822, @shahor02 , @noferini

This should fix the issue with the fact that ADAPOS Is now sending DPVAL instead of RAW types (@wiechula, @martenole : you might need to fix this in your ongoing development for DCS DataPoints processing).

I tested the changes in GRP + getValue function of DataPointCompositeObject, and it worked.

Chiara

@chiarazampolli chiarazampolli mentioned this pull request Mar 13, 2022
Merged
@chiarazampolli chiarazampolli changed the title Adapt to type sent by DCS + macros to populate and read the GRP DCS config entry [WIP] Adapt to type sent by DCS + macros to populate and read the GRP DCS config entry Mar 14, 2022
@chiarazampolli
Copy link
Copy Markdown
Collaborator Author

chiarazampolli commented Mar 14, 2022

Changed to WIP to see how today's test behave.

Chiara

@chiarazampolli chiarazampolli changed the title [WIP] Adapt to type sent by DCS + macros to populate and read the GRP DCS config entry Adapt to type sent by DCS + macros to populate and read the GRP DCS config entry Mar 14, 2022
@chiarazampolli
Copy link
Copy Markdown
Collaborator Author

chiarazampolli commented Mar 14, 2022

Working with today's tests for MFT, TOF, MCH, EMCAL, GRP, so moving to ready for review.

@shahor02
Copy link
Copy Markdown
Collaborator

shahor02 commented Mar 17, 2022

Hi @chiarazampolli there are conflicts to resolve...

@chiarazampolli
Copy link
Copy Markdown
Collaborator Author

chiarazampolli commented Mar 17, 2022

Hi @shahor02 ,

Yes, because meanwhile also detectors committed similar fixes :-)
I will take care, I need also to move the GRP CCDB object from Calib to Config, as we discussed today.

Chiara

@chiarazampolli
Copy link
Copy Markdown
Collaborator Author

chiarazampolli commented Mar 17, 2022

@shahor02 , conflicts solved.
I think that this PR is ready, after the tests are passed.

@chiarazampolli
Copy link
Copy Markdown
Collaborator Author

chiarazampolli commented Mar 19, 2022

Hi @shahor02 ,
At your convenience, could you check this PR?
Thanks!
Chiara

shahor02
shahor02 requested changes Mar 19, 2022
View reviewed changes
@shahor02 shahor02 merged commit 078d877 into AliceO2Group:dev Mar 20, 2022
@chiarazampolli chiarazampolli deleted the GRPmacros branch May 16, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahor02 shahor02 shahor02 approved these changes

@noferini noferini Awaiting requested review from noferini noferini is a code owner

@davidrohr davidrohr Awaiting requested review from davidrohr

@wiechula wiechula Awaiting requested review from wiechula

@iouribelikov iouribelikov Awaiting requested review from iouribelikov

@bovulpes bovulpes Awaiting requested review from bovulpes

@rpezzi rpezzi Awaiting requested review from rpezzi

@mconcas mconcas Awaiting requested review from mconcas mconcas is a code owner

@mfasDa mfasDa Awaiting requested review from mfasDa

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chiarazampolli @shahor02