Add draft for TRD DCS processor#8170
Merged
TimoWilken merged 2 commits intoAliceO2Group:devfrom Mar 16, 2022
Merged
Conversation
martenole
requested review from
bazinski,
jolopezl and
tdietel
as code owners
tdietel
reviewed
Feb 23, 2022
tdietel
reviewed
Feb 23, 2022
Contributor
tdietel
left a comment
tdietel
left a comment
There was a problem hiding this comment.
I have a few comments. The main one is the one around the converter. Do you want to test this before the merge?
Contributor
There was a problem hiding this comment.
I think DIM usually works with single precision float. Is the conversion to double intentional?
Contributor
Author
There was a problem hiding this comment.
I have no idea about the precision of the data types.. All I have is the list from Denise. But if its usually single precision I'll use RAW_FLOAT instead
Contributor
There was a problem hiding this comment.
Ok, I guess we will see it in the tests.
- currently storing only information for the gas parameters (min/max/mean for defined period)
tdietel
approved these changes
Mar 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @tdietel
this is a first version of the DCS data point processing in O2. So far I am only taking into account the gas parameters and storing one CCDB object for them. Could you please have a look and see if it makes sense like that? I have to admit I tested it now only with a simulation. I am not sure that the format of the DCS data points is really the same in data. This I need to check probably with Denise.
In order to run the processing with a local CCDB:
Detectors/TRD/calibration/macros/makeTRDCCDBEntryForDCS.CCheers,
Ole