[o2-sim] En-/disable hit creation per detector#8149
Merged
sawenzel merged 1 commit intoAliceO2Group:devfrom Feb 14, 2022
Merged
[o2-sim] En-/disable hit creation per detector#8149sawenzel merged 1 commit intoAliceO2Group:devfrom
sawenzel merged 1 commit intoAliceO2Group:devfrom
Conversation
benedikt-voelkel
requested review from
a team,
bovulpes,
iouribelikov,
rpezzi and
sawenzel
as code owners
Be able to en-/disable hit creation of detectors while still building
the geometry. This is an extension to the -m/--skipModules options.
* introduce --readoutDetectors and --skipReadoutDetectors options
if a passive module name is passed for either of the options it will
be ignored
* --readoutDetectors det_1 ... det_N
* if det_i specified, only the given detectors will be readout
* if det_i not contained in active modules (see -m/--skipModules), it
takes precedence and det_i is added to active modules
* if not specified, all detectors will be readout which are in line
with the -m and --skipModules options
* --skipReadoutDetectors det_1 ... det_N
* given detectors will not produce any hits
* has no effect on the constructed geometry
* take care of corner cases such as
--skipModules m --readoutDetectors m --skipReadoutDetectors m
in which case m is not built at all and therefore not readout
benedikt-voelkel
force-pushed
the
build-geom-sens
branch
from
677b2c3 to
e141d9f
Compare
| "skipModules", bpo::value<std::vector<std::string>>()->multitoken()->default_value(std::vector<std::string>({""}), ""), "list of detectors to skip (precendence over -m")( | ||
| "modules,m", bpo::value<std::vector<std::string>>()->multitoken()->default_value(std::vector<std::string>({"all"}), "all modules"), "list of modules included in geometry")( | ||
| "skipModules", bpo::value<std::vector<std::string>>()->multitoken()->default_value(std::vector<std::string>({""}), ""), "list of modules excluded in geometry (precendence over -m")( | ||
| "readoutDetectors", bpo::value<std::vector<std::string>>()->multitoken()->default_value(std::vector<std::string>(), ""), "list of detectors creating hits, all if not given; added to to active modules")( |
Contributor
Author
There was a problem hiding this comment.
maybe help message needs to be more clear, such as "list of detectors creating hits; if not given, all detectors compatible with -m/skipModules flag are readout; if given but not yet compatible with -m/--skipModules, detectors are added for geometry construction as well"
sawenzel
approved these changes
Feb 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be able to en-/disable hit creation of detectors while still building
the geometry. This is an extension to the -m/--skipModules options.
introduce --readoutDetectors and --skipReadoutDetectors options
if a passive module name is passed for either of the options it will
be ignored
--readoutDetectors det_1 ... det_N
takes precedence and det_i is added to active modules
with the -m and --skipModules options
--skipReadoutDetectors det_1 ... det_N
take care of corner cases such as
--skipModules m --readoutDetectors m --skipReadoutDetectors m
in which case m is not built at all and therefore not readout