Merged
Conversation
shahor02
reviewed
Dec 9, 2021
| std::vector<float> vAmplitudes(nFT0Channels, 0.); | ||
| // filling FT0 table | ||
| for (auto& ft0RecPoint : ft0RecPoints) { | ||
| std::vector<float> vAmplitudes(nFT0Channels, 0.); |
Collaborator
There was a problem hiding this comment.
this means an allocation of a new vector for every trigger, I would simply get rid of it.
Collaborator
Author
There was a problem hiding this comment.
Yes, see mattermost. I already confirmed that.
https://mattermost.web.cern.ch/alice/pl/1pwtw45b1trmiygnp3tupu6qkr
Contributor
There was a problem hiding this comment.
set amplitude vector in zero before each event #7848,
I think FV0 and FDD need similar fix
ezradlesser
pushed a commit
to ezradlesser/AliceO2
that referenced
this pull request
Dec 15, 2021
* Fix T0 filling * fix also V0A and FDD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.