CCDBApi: protection against missing X509_CERT_DIR env var#6984
Merged
sawenzel merged 1 commit intoAliceO2Group:devfrom Sep 7, 2021
Merged
Conversation
aphecetche
requested review from
a team,
Barthelemy,
costing and
sawenzel
as code owners
Collaborator
Author
ktf
approved these changes
Sep 7, 2021
sawenzel
approved these changes
Sep 7, 2021
costing
approved these changes
Sep 7, 2021
aphecetche
deleted the
ccdb-api-x509-cert-dir-should-not-be-mandatory
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Atlantic777 @costing @sawenzel
Here's a small change for your consideration.
Assuming I understand correctly that the CCDB is not 100% tied to AliEn, I would expect it to work as it was before #5826 even if some env variables are not set.
As far as I can tell with this minimal change the ccdb related tests of O2 (
ctest -L ccdb) work even without the env var set, otherwise they crash (and any attempt to use the CcdbApi crash as well).(tested on macOS, with AliceO2 built with Spack, but I'd say that's not relevant as much as added requirement on some variables to be present if they are not really, or not always).