Fix color usage in Debug GUI (avoid ambiguous static initialization order)#5849
Merged
davidrohr merged 1 commit intoAliceO2Group:devfrom Apr 2, 2021
Merged
Conversation
Member
|
We should probably move everything to PaletteHelpers, indeed. If this fixes your problem we can merge it, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ktf: this fixes the issue I mentioned in #5845
The problem is that you have static variables in different compilation units that depend on each other in the initialization, but the order is not well defined. This fix solves that using references, which is not nice but it fixes the current problem.
There is a very similar problem also in Framework/GUISupport/src/FrameworkGUIDataRelayerUsage.cxx. Not sure if you want to apply the same fix there, or reorganize the PaletteHelpers, since this is a bit error-prone.