[WIP] Create template for TRD vDrift calibration#5838
Closed
martenole wants to merge 2 commits intoAliceO2Group:devfrom
Closed
[WIP] Create template for TRD vDrift calibration#5838martenole wants to merge 2 commits intoAliceO2Group:devfrom
martenole wants to merge 2 commits intoAliceO2Group:devfrom
Conversation
- had to move GPUTRDSpacePointInternal to extra header file (in next step this can be replaced in O2 with CalibratedTracklet, while for AliRoot the definition is kept) - same will need to be done for the struct which is actually used for the calibration
Contributor
Author
|
@aberdnikova and @SvenHoppner I am closing this one, since it is superseded by #5894 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@aschmah @aberdnikova @SvenHoppner,
this is a template for the vDrift calibration. I did not yet add another DPL device. Instead, the calibration is simply appended to the
o2-trd-global-trackingworkflow. So when you run that workflow also the calibration template is called. At the moment it creates a root file with a dummy histogram.In principle we just need to replace the
GPUTRDSpacePointInternalwith the data type which Sven creates for the angular deviations. Afterwards you can add everything you needed into theCalibVDrift::process()method.@davidrohr please ignore for the moment. Instead of
GPUTRDSpacePointInternalI want to useCalibratedTrackletwhen built with O2. Also I have not yet tested whether it is still working with AliRoot