[ITS vertexer] Fix compilation with ITS debug#5383
Merged
davidrohr merged 2 commits intoAliceO2Group:devfrom Feb 6, 2021
Merged
[ITS vertexer] Fix compilation with ITS debug#5383davidrohr merged 2 commits intoAliceO2Group:devfrom
davidrohr merged 2 commits intoAliceO2Group:devfrom
Conversation
mconcas
requested review from
bovulpes,
iouribelikov and
shahor02
as code owners
mconcas
force-pushed
the
fix-its-debug-mode
branch
2 times, most recently
from
5ece5a0 to
613ecd0
Compare
mconcas
force-pushed
the
fix-its-debug-mode
branch
from
613ecd0 to
e6263f0
Compare
davidrohr
approved these changes
Feb 5, 2021
Collaborator
davidrohr
left a comment
davidrohr
left a comment
There was a problem hiding this comment.
Looks OK to me, errors seem unrelated.
Shall I squash and merge, or is more coming?
Collaborator
|
@ktf @TimoWilken : There seem to be several ctests failing randomly in the last days, most of them framework test. |
Member
|
yes, me. I think it's #5484. One fix committed. Another one coming. |
Collaborator
Author
Sorry, missed last part. It's mergeable. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should not change anything as the flag is disabled by default.
I additionaly need the {nv, h}cc compiler to know about some dataformat methods also when compiling host code.