Skip to content

TRD: Fix trigger records (digitizer), and MC step size (hits)#4680

Merged
ktf merged 4 commits intoAliceO2Group:devfrom
jolopezl:TRDdevelop
Oct 26, 2020
Merged

TRD: Fix trigger records (digitizer), and MC step size (hits)#4680
ktf merged 4 commits intoAliceO2Group:devfrom
jolopezl:TRDdevelop

Conversation

@jolopezl
Copy link
Copy Markdown
Contributor

@jolopezl jolopezl commented Oct 24, 2020

  • Fix the trigger records: move the TRD event trigger to the steering code with a bit improved trigger logic (passing all checks of embedding and pileup).
  • Fix a maximum MC step (see Detector.cxx) with a good empirical value for the moment.
  • Fix analyze digit labels macro for new labels IO for having the embedding and pileup checker working again.

@jolopezl jolopezl requested a review from a team as a code owner October 24, 2020 18:42
shahor02
shahor02 previously approved these changes Oct 25, 2020
Copy link
Copy Markdown
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jolopezl

Looks fine. See one comment below.

@sawenzel
Copy link
Copy Markdown
Collaborator

@ktf: Is this already the new CI setup at work here? Just wondering, because codechecker seems to be gone but I also don't see it inside the gpu build.

@davidrohr
Copy link
Copy Markdown
Collaborator

@ktf @sawenzel @TimoWilken : The codechekcker is gone and the GPU CI runs the codeckecker. It builds o2fullci, which includes the codechecker.
The codechecker output is only shown when it fails at the moment.
Could we perhaps add the codechecker log to the logs that are always shown for this CI, like it is for O2 itself?

@sawenzel
Copy link
Copy Markdown
Collaborator

sawenzel commented Oct 26, 2020

@ktf @TimoWilken @davidrohr: I think the log should be shown otherwise one cannot be sure that it actually ran or what it did. Besides: since this CI setup is now actually running some sort of pipeline/stages, it would be a cool thing to report success/failure of the substages. Would this be possible? Gitlab CI has a nice feature like this but I guess it should be trivial to accomplish in our case too.

Copy link
Copy Markdown
Collaborator

@bazinski bazinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose the 3000 us can be fixed later on when we change the class in lieu of discussion on friday.


// Trigger parameters
bool mTriggeredEvent = false;
static constexpr double READOUT_TIME = 3000; // the time the readout takes, as 30 TB = 3 micro-s.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a double? and more importantly given the discussion about 30 and 60 timebins on friday, this is going to tie it down. Similarly for the next 2 fields, or do we never simulate for Kr ?

@ktf ktf merged commit ca98185 into AliceO2Group:dev Oct 26, 2020
@jolopezl jolopezl deleted the TRDdevelop branch October 26, 2020 12:11
tklemenz pushed a commit to tklemenz/AliceO2 that referenced this pull request Nov 12, 2020
…2Group#4680)

* Fix TRD trigger records
* Add getADCsum method to the Digit class
* Fix analyze digit labels macro for new labels IO
* Drop unnecessary conditional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

6 participants