TRD: Fix trigger records (digitizer), and MC step size (hits)#4680
TRD: Fix trigger records (digitizer), and MC step size (hits)#4680ktf merged 4 commits intoAliceO2Group:devfrom jolopezl:TRDdevelop
Conversation
|
@ktf: Is this already the new CI setup at work here? Just wondering, because codechecker seems to be gone but I also don't see it inside the gpu build. |
|
@ktf @sawenzel @TimoWilken : The codechekcker is gone and the GPU CI runs the codeckecker. It builds o2fullci, which includes the codechecker. |
|
@ktf @TimoWilken @davidrohr: I think the log should be shown otherwise one cannot be sure that it actually ran or what it did. Besides: since this CI setup is now actually running some sort of pipeline/stages, it would be a cool thing to report success/failure of the substages. Would this be possible? Gitlab CI has a nice feature like this but I guess it should be trivial to accomplish in our case too. |
bazinski
left a comment
There was a problem hiding this comment.
I suppose the 3000 us can be fixed later on when we change the class in lieu of discussion on friday.
|
|
||
| // Trigger parameters | ||
| bool mTriggeredEvent = false; | ||
| static constexpr double READOUT_TIME = 3000; // the time the readout takes, as 30 TB = 3 micro-s. |
There was a problem hiding this comment.
Why a double? and more importantly given the discussion about 30 and 60 timebins on friday, this is going to tie it down. Similarly for the next 2 fields, or do we never simulate for Kr ?
…2Group#4680) * Fix TRD trigger records * Add getADCsum method to the Digit class * Fix analyze digit labels macro for new labels IO * Drop unnecessary conditional
Uh oh!
There was an error while loading. Please reload this page.