Skip to content

Disable flp2epn-distributed test temporarily#390

Merged
ktf merged 1 commit intoAliceO2Group:devfrom
dberzano:disable-test
May 19, 2017
Merged

Disable flp2epn-distributed test temporarily#390
ktf merged 1 commit intoAliceO2Group:devfrom
dberzano:disable-test

Conversation

@dberzano
Copy link
Copy Markdown
Contributor

No description provided.

@ktf ktf self-requested a review May 19, 2017 12:31
Copy link
Copy Markdown
Member

@ktf ktf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed we should merge this to avoid spurious errors and open a ticket about the test failing.

@ktf ktf merged commit a5cd2f3 into AliceO2Group:dev May 19, 2017
@matthiasrichter
Copy link
Copy Markdown
Collaborator

There seems to be a strange issue when running the unit tests in the CI. Whenever a test which has failed is disabled, another tests fails which had been ok before. Also the disabled here had been working before.

@ktf
Copy link
Copy Markdown
Member

ktf commented May 22, 2017

Indeed, looks like a timeout or something like that. @dberzano can you look into it?

@dberzano
Copy link
Copy Markdown
Contributor Author

Yep

@dberzano
Copy link
Copy Markdown
Contributor Author

Hi @matthiasrichter, @ktf - I don't see the problem any longer, do you?

@matthiasrichter
Copy link
Copy Markdown
Collaborator

Hi Dario, the last message from the Alice Builder is from 16:33 on this issue #370 (comment), I think the problem is still there.

@matthiasrichter
Copy link
Copy Markdown
Collaborator

Follow up on this: there was a real problem with the failing unit test. But it looks like that the condition whether it was failing or not was depending on the history of unit tests as the test was not failing when the flp2epn-distributed test was failing. Can the actual error message from a failing test be part of the log? Right now that seems to be missing.

@rbx
Copy link
Copy Markdown
Contributor

rbx commented May 30, 2017

I don't know from where this issue originated, but I would suggest to re-enable the test. If it is something unique to the flp2epn-distributed, then I will fix the origin of the fail. We shouldn't hide the problem by disabling the test. (Sorry if I am missing some parts of the discussion not present here!)

I tried to reproduce any failures on MacOS/Linux but couldn't. @matthiasrichter Indeed, seeing the actuall failure message would be very useful :).

knopers8 added a commit to knopers8/AliceO2 that referenced this pull request Sep 7, 2020
…iceO2Group#390)

* [QC-292] Make multi-node setups work nicely with ServiceDiscovery

* Service Discovery - common names but unique IDs
mbroz84 pushed a commit to mbroz84/AliceO2 that referenced this pull request Mar 16, 2022
* Add Tree variables

* Fix clang format

* apply the comments

* Add tree branches related to Xic selection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants