Skip to content

Add ITS headers and improve invalid origin / description#388

Merged
ktf merged 1 commit intoAliceO2Group:devfrom
ktf:dev-add-inv-its
May 19, 2017
Merged

Add ITS headers and improve invalid origin / description#388
ktf merged 1 commit intoAliceO2Group:devfrom
ktf:dev-add-inv-its

Conversation

@ktf
Copy link
Copy Markdown
Member

@ktf ktf commented May 19, 2017

No description provided.

@ktf ktf requested review from matthiasrichter and mkrzewic May 19, 2017 09:59
@ktf ktf mentioned this pull request May 19, 2017
Merged
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented May 19, 2017

Error while checking build/O2/o2 for 607ffc5:

sw/BUILD/O2-latest/log
+ DEVEL_SOURCES=/mnt/mesos/sandbox/sandbox/O2
+ '[' /mnt/mesos/sandbox/sandbox/O2 '!=' /mnt/mesos/sandbox/sandbox/sw/SOURCES/O2/dev/0 ']'
+ perl -p -i -e 's|/mnt/mesos/sandbox/sandbox/sw/SOURCES/O2/dev/0|/mnt/mesos/sandbox/sandbox/O2|' compile_commands.json
+ ln -sf /mnt/mesos/sandbox/sandbox/sw/BUILD/b3b37fa96d85a0e858b2e6ac9dda2e680aec17de/O2/compile_commands.json /mnt/mesos/sandbox/sandbox/O2/compile_commands.json
+ [[ -n 1 ]]
+ make test
Running tests...
Test project /mnt/mesos/sandbox/sandbox/sw/BUILD/b3b37fa96d85a0e858b2e6ac9dda2e680aec17de/O2
      Start  1: testMessageList
 1/16 Test  #1: testMessageList ..................   Passed    0.00 sec
      Start  2: testDataHeader
 2/16 Test  #2: testDataHeader ...................   Passed    0.57 sec
      Start  3: testTimeStamp
 3/16 Test  #3: testTimeStamp ....................   Passed    0.56 sec
      Start  4: testBasicHits
 4/16 Test  #4: testBasicHits ....................   Passed    0.67 sec
      Start  5: TimeFrameTest
 5/16 Test  #5: TimeFrameTest ....................   Passed    0.63 sec
      Start  6: testTPCBase
 6/16 Test  #6: testTPCBase ......................   Passed    0.50 sec
      Start  7: testTPCCalDet
 7/16 Test  #7: testTPCCalDet ....................   Passed    0.93 sec
      Start  8: testTPCMapper
 8/16 Test  #8: testTPCMapper ....................   Passed    0.46 sec
      Start  9: testTPCSyncPatternMonitor
 9/16 Test  #9: testTPCSyncPatternMonitor ........   Passed    0.51 sec
      Start 10: testTPCAdcClockMonitor
10/16 Test #10: testTPCAdcClockMonitor ...........   Passed    0.50 sec
      Start 11: testTPCElectronTransport
11/16 Test #11: testTPCElectronTransport .........   Passed    0.86 sec
      Start 12: testTPCGEMAmplification
12/16 Test #12: testTPCGEMAmplification ..........   Passed   30.07 sec
      Start 13: testTPCSimulation
13/16 Test #13: testTPCSimulation ................   Passed    0.43 sec
      Start 14: run_flp2epn_distributed
14/16 Test #14: run_flp2epn_distributed ..........***Failed  Required regular expression not found.Regex=[acknowledged after
]  5.02 sec
      Start 15: testExampleModule1
15/16 Test #15: testExampleModule1 ...............   Passed    0.01 sec
      Start 16: O2MessageMonitorTest
16/16 Test #16: O2MessageMonitorTest .............   Passed    0.48 sec

94% tests passed, 1 tests failed out of 16

Total Test time (real) =  42.24 sec

The following tests FAILED:
	 14 - run_flp2epn_distributed (Failed)
Errors while running CTest

Full log here.

@ktf
Copy link
Copy Markdown
Member Author

ktf commented May 19, 2017

Possibilities:

  • BAD\0: I like it.
  • NIL: I like it.
  • FFF\0: I do not like it, because FFF\0 it's 0x00464646, not 0x00ffffff.

So I will let @matthiasrichter @mkrzewic pick one of the two above.

mkrzewic
mkrzewic approved these changes May 19, 2017
View reviewed changes
DataFormats/Headers/src/DataHeader.cxx
//possible data types
const o2::Header::DataDescription o2::Header::gDataDescriptionAny ("***************");
const o2::Header::DataDescription o2::Header::gDataDescriptionInvalid (" ");
const o2::Header::DataDescription o2::Header::gDataDescriptionInvalid ("INVALID ");
Copy link
Copy Markdown
Contributor

@mkrzewic mkrzewic May 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we keep INVALID here? Or should we also change it to NIL or so for consistency?

Copy link
Copy Markdown
Member Author

@ktf ktf May 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should avoid as much as possible to have the same values for origins and descriptions.

@ktf ktf merged commit 3c944d4 into AliceO2Group:dev May 19, 2017
@ktf ktf deleted the dev-add-inv-its branch May 19, 2017 18:38
knopers8 pushed a commit to knopers8/AliceO2 that referenced this pull request Sep 7, 2020
@peressounko
First version of PHOS QC (AliceO2Group#388)
077968c 
* First PHOS QC

Barth's comments applied

* Compilation fixes

* warning fix

Co-authored-by: Dmitri Peresunko <Dmitri.Peresunko@cern.ch>
mbroz84 pushed a commit to mbroz84/AliceO2 that referenced this pull request Mar 16, 2022
@ddobrigk
V0 builder now able to do mat corr (AliceO2Group#388)
b109f21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthiasrichter matthiasrichter Awaiting requested review from matthiasrichter

1 more reviewer

@mkrzewic mkrzewic mkrzewic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ktf @alibuild @mkrzewic