Skip to content

Regain possibility to do MC truth handling for TPC digits manually#385

Merged
sawenzel merged 1 commit intoAliceO2Group:devfrom
sawenzel:swenzel/tpcMCtruthcmp
May 19, 2017
Merged

Regain possibility to do MC truth handling for TPC digits manually#385
sawenzel merged 1 commit intoAliceO2Group:devfrom
sawenzel:swenzel/tpcMCtruthcmp

Conversation

@sawenzel
Copy link
Copy Markdown
Collaborator

  • Needed in order to be able to test/debug/evaluate
    approaches based on FairLinks (solution based on compile time switches)

  • Small adjustment to TPC runscript: Offer
    possibility to use Box generator or GeneratorFromFile

@authors: Andreas Matthis, Sandro Wenzel

@sawenzel sawenzel force-pushed the swenzel/tpcMCtruthcmp branch from 219df6b to 845360d Compare May 19, 2017 06:21
@sawenzel sawenzel requested a review from wiechula May 19, 2017 06:22
Copy link
Copy Markdown
Member

@ktf ktf May 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not simply using a struct as the key?

struct MCID{
unsigned int eventId : 15; // 32k event Id possible
unsigned int trackId: 17; // 128K tracks possible
};

Also why using a map rather than a sorted vector with key and value in the same bitfield?

struct MCIDValue {
  unsigned int eventId : 15; // 32k event Id possible 
  unsigned int trackId: 17; // 128K tracks possible
  unsigned int occurences : 32; // 4G occurrences possible   
}
std::vector<MCID> mMCID;

this has the added value you can use less bits for the occurrences and should be almost two orders of magnitude more compact.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you say is correct and it has been discussed in similar form among the TPC developers already. However, this commit merely "reverts" to what was already available before ... just to debug and compare to the FairLinks. I will add your comments as future ideas.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@dberzano
Copy link
Copy Markdown
Contributor

@sawenzel I believe the conflict comes from my merged PR #387

 * Needed in order to be able to test/debug/evaluate
   approaches based on FairLinks (solution based on compile time switches)

 * Small adjustment to TPC runscript: Offer
   possibility to use Box generator or GeneratorFromFile

@authors: Andreas Matthis, Sandro Wenzel
@sawenzel sawenzel force-pushed the swenzel/tpcMCtruthcmp branch from 845360d to b0b1a01 Compare May 19, 2017 08:42
Copy link
Copy Markdown
Collaborator

@wiechula wiechula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it is fine, please go ahead

@sawenzel sawenzel merged commit ddcaaac into AliceO2Group:dev May 19, 2017
@sawenzel sawenzel deleted the swenzel/tpcMCtruthcmp branch May 19, 2017 14:00
knopers8 pushed a commit to knopers8/AliceO2 that referenced this pull request Sep 7, 2020
mbroz84 pushed a commit to mbroz84/AliceO2 that referenced this pull request Mar 16, 2022
* foundBC index added to EvSel table

* foundFT0, foundFV0 and foundBC as index columns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants