[EMCAL-630] DPL component for Raw to Cell conversion#3079
Merged
sawenzel merged 1 commit intoAliceO2Group:devfrom May 14, 2020
Merged
[EMCAL-630] DPL component for Raw to Cell conversion#3079sawenzel merged 1 commit intoAliceO2Group:devfrom
sawenzel merged 1 commit intoAliceO2Group:devfrom
Conversation
Contributor
|
This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days. |
hahassan7
changed the title
mfasDa
requested changes
May 10, 2020
Collaborator
mfasDa
left a comment
mfasDa
left a comment
There was a problem hiding this comment.
For the moment there are a couple of small modifications, however the component is not yet adapted to timeframe-based format. This needs to be done as a second step.
Contributor
Author
|
The failing test is not due to this commit. I think the pull request can be merged. |
mfasDa
previously approved these changes
May 13, 2020
Collaborator
|
For merging the commit should be squash-merged, keeping only the commit message of the first commit. |
-DPL component for Raw to Cell conversion -Adapting the component to the new RecoWorkflow
Contributor
Author
|
Pull request can be merged now. |
amorsch
pushed a commit
to amorsch/AliceO2
that referenced
this pull request
May 28, 2020
-DPL component for Raw to Cell conversion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.