Skip to content

Redeclaration of private constexpr class member to avoid linker error #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawenzel merged 1 commit into from
Mar 29, 2017
Merged

Redeclaration of private constexpr class member to avoid linker error #288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Utilities/DataFlow/src/SubframeBuilderDevice.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,12 @@
#include "Headers/DataHeader.h"
#include "FairMQProgOptions.h"

// temporary hack to solve issue 279; linking problem for this constexpr
// variable
// From C++11 on, constexpr static data members are implicitly inlined. Redeclaration
// is still permitted, but deprecated. Some compilers do not implement this standard
// correctly. It also has to be noticed that this error does not occur for all the
// other public constexpr members
constexpr uint32_t AliceO2::DataFlow::SubframeBuilderDevice::mOrbitsPerTimeframe;
constexpr uint32_t AliceO2::DataFlow::SubframeBuilderDevice::mOrbitDuration;
constexpr uint32_t AliceO2::DataFlow::SubframeBuilderDevice::mDuration;

using HeartbeatHeader = AliceO2::Header::HeartbeatHeader;
Expand Down