Redeclaration of private constexpr class member to avoid linker error#288
Merged
sawenzel merged 1 commit intoAliceO2Group:devfrom Mar 29, 2017
Merged
Redeclaration of private constexpr class member to avoid linker error#288sawenzel merged 1 commit intoAliceO2Group:devfrom
sawenzel merged 1 commit intoAliceO2Group:devfrom
Conversation
This is a follow up for the previously committed fix for issue AliceO2Group#279, linker problem with constexpr class member. Added redeclaration of all private constexpr data members and enhancing the comment in the code. From C++11 on, constexpr static data members are implicitly inlined. Redeclaration is still permitted, but deprecated. Some compilers do not implement this standard correctly. It also has to be noticed that this error does not occur for all the other public constexpr members. Closing AliceO2Group#282. Whether the variables have to be constexpr (and fixed) or configurable will be handled when the work on the devices is resumed.
knopers8
pushed a commit
to knopers8/AliceO2
that referenced
this pull request
Sep 7, 2020
* A non-static Version * Forgot a file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up for the previously committed fix for issue #279,
linker problem with private constexpr class member.
Added redeclaration of all private constexpr data members and enhancing
the comment in the code.
From C++11 on, constexpr static data members are implicitly inlined.
Redeclaration is still permitted, but deprecated. Some compilers do
not implement this standard correctly. It also has to be noticed that
this error does not occur for all the other public constexpr members.
Closing #282. Whether the variables have to be constexpr (and fixed) or
configurable will be handled when the work on the devices is resumed.