Skip to content

MFT: add macro for conversion digits to raw#2176

Merged
davidrohr merged 3 commits intoAliceO2Group:devfrom
bovulpes:mft-raw
Jul 14, 2019
Merged

MFT: add macro for conversion digits to raw#2176
davidrohr merged 3 commits intoAliceO2Group:devfrom
bovulpes:mft-raw

Conversation

@bovulpes
Copy link
Copy Markdown
Collaborator

@bovulpes bovulpes commented Jul 9, 2019

This is a clone of the corresponding macro for the ITS, adapted to the MFT read-out.

Copy link
Copy Markdown
Collaborator

@davidrohr davidrohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in principle.

After the CMake migration yesterday, all macros should be added explicitly to the tests in the CMake. Could you please have a look at macros/CMakeLists.txt

@aphecetche
Copy link
Copy Markdown
Collaborator

@bovulpes let me know if you need help editing the new CMakeLists.txt

@bovulpes
Copy link
Copy Markdown
Collaborator Author

Thanks @aphecetche I just duplicated the ITS entries, I hope it works.

@aphecetche
Copy link
Copy Markdown
Collaborator

@bovulpes It should. But note that you can also check locally whether it's working or not using either :

ALIBUILD_O2_TESTS=1 aliBuild --defaults o2 build O2

or

aliBuild --defaults o2 build O2
eval $(alienv load O2/latest)
cd sw/BUILD/O2-latest/O2
ctest -L macro -R mft

@bovulpes
Copy link
Copy Markdown
Collaborator Author

bash: ctest: command not found ??

@aphecetche
Copy link
Copy Markdown
Collaborator

If you don't have cmake installed locally (i.e. just have the one installed by aliBuild), then for the second option above you also need to load CMake/latest from alienv.

@bovulpes
Copy link
Copy Markdown
Collaborator Author

OK thanks: 100% tests passed, 0 tests failed out of 16

@davidrohr davidrohr merged commit fb06c59 into AliceO2Group:dev Jul 14, 2019
MichaelLettrich pushed a commit that referenced this pull request Jul 24, 2019
* MFT: add macro for conversion digits to raw

* MFT: add macro for decoding MFT raw data

* MFT: add new macros to CMakeLists
knopers8 pushed a commit to knopers8/AliceO2 that referenced this pull request Oct 23, 2019
* MFT: add macro for conversion digits to raw

* MFT: add macro for decoding MFT raw data

* MFT: add new macros to CMakeLists
carlos-soncco pushed a commit to carlos-soncco/AliceO2 that referenced this pull request Oct 28, 2019
* MFT: add macro for conversion digits to raw

* MFT: add macro for decoding MFT raw data

* MFT: add new macros to CMakeLists
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants