TRD digitizer signals to ADC O2-455#2009
Merged
sawenzel merged 2 commits intoAliceO2Group:devfrom May 27, 2019
jolopezl:trd-digitizer-adc
Merged
TRD digitizer signals to ADC O2-455#2009sawenzel merged 2 commits intoAliceO2Group:devfrom jolopezl:trd-digitizer-adc
sawenzel merged 2 commits intoAliceO2Group:devfrom
jolopezl:trd-digitizer-adc
Conversation
Contributor
Author
|
Failing tests not related to this PR. |
Collaborator
|
There is again a general problem with a test, all PRs are currently failing... |
Member
|
@dberzano I ran the test standalone and it seems to work. How is it actually executed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One more step toward the full digitization chain. Signal conversion to ADC values completed with the number of time bins defaulted to 30 as discussed previously in meetings.
Last thing to do (and next): Filling vectors and passing info to the DPL.
https://alice.its.cern.ch/jira/browse/O2-455